Tachyon's `StackTraceCollector` has two different ways to set `skip_idle`

[KowalskiThomas]

I was looking at the code in Tachyon and I think I've found something that isn't quite right (or at least is misleading and needs to be documented?)

In the StackTraceCollector, it seems like self.skip_idle is set but never used, as every collect method gets another skip_idle parameter that they use in _iter_stacks (or their calls to parent class' methods).

Based on the code for e.g. live_collector, it seems like the pattern is to use the attribute, not a parameter.

Linked PRs

• gh-145458: use self.skip_idle #145459

[picnixz]

I was looking at the code in Tachyon and I think I've found something that isn't quite right (or at least is misleading and needs to be documented?)

When you are not sure about something, please avoid create draft PRs and wait for a maintainer to acknowledge the issue. You can say that you have a PR ready in case this is acknowledge but please avoid opening PRs that are not sure to be merged.

[KowalskiThomas]

Sounds good, noted. Sorry about this. I'll avoid doing this in the future.

[encukou]

cc @pablogsal

[KowalskiThomas]

I think we can close this, right? Now that #145459 is merged.