Strip closing keywords from the body#15595
Merged
rak-phillip merged 2 commits intorancher:masterfrom Nov 19, 2025
Merged
Conversation
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
4ccb9b4 to
272bac2
Compare
codyrancher
previously approved these changes
Nov 17, 2025
Member
codyrancher
left a comment
There was a problem hiding this comment.
I'm fine with the change. I did have one thought though. May instead of replacing with white space we do something like "Original text redacted by port-pr.yaml" to avoid confusion and make it easier to track in the future.
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Member
Author
I like this approach. Ready for another review. |
codyrancher
approved these changes
Nov 17, 2025
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This attempts to strip closing keywords from the body of a backport PR.
Occurred changes and/or fixed issues
Technical notes summary
Previous attempts to prevent altering backport PR milestones haven't worked. I think that a straightforward approach will be to attempt removal of closing keywords from the PR body, this should stop the
.github/workflows/scripts/pr-gh-project.jsscript from altering the milestone based on the linked issues.Areas or cases that should be tested
Backporting PRs should no longer set the milestone to that of the original issue.
Areas which could experience regressions
This change could inadvertently clobber the body of the backport PR in undefined ways.
Screenshot/Video
NA
Checklist