Skip to content

fix format in "Age" column for CRD#15712

Merged
richard-cox merged 4 commits intorancher:masterfrom
enneitex:fix-age-column
Jan 21, 2026
Merged

fix format in "Age" column for CRD#15712
richard-cox merged 4 commits intorancher:masterfrom
enneitex:fix-age-column

Conversation

@enneitex
Copy link
Copy Markdown
Contributor

@enneitex enneitex commented Oct 23, 2025

Summary

Fixes #15711

If the column has the widely used name Age, use the LiveDate formatter

Before:
image

After:
image

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@richard-cox richard-cox added this to the v2.14.0 milestone Nov 26, 2025
@richard-cox richard-cox self-requested a review January 19, 2026 07:04
Copy link
Copy Markdown
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the slow progress.

I've given the latest change a review and looking good. There's something odd going on with our gates though, they;ve been approved to run but aren't.

Would you be able to rebase and see if that kick starts them?

@tomleb FWIW this means that globalrolebindings will now use the age column (given they have col name AGE)

@enneitex
Copy link
Copy Markdown
Contributor Author

Hi, no worries!
One e2e test failed but I'm not sure why.

@richard-cox
Copy link
Copy Markdown
Member

@enneitex they can be temperamental, i'll shepherd it through and if there's a genuine issue let you know

@richard-cox richard-cox merged commit 31de1ff into rancher:master Jan 21, 2026
118 of 121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Colum Age in custom resource lists is not formatted to a LiveDate

3 participants