Implements RcIcon from the design system#15886
Conversation
I refactored the rest of the places we use status so the code could be shared.
There was a problem hiding this comment.
I placed utils inside the components library due to extensive issues with referencing imports outside of this directory via aliases or relative paths.
Depending on what you choose I ran into issues with:
- Building extensions
- Building storybook
- Running storybook
- Importing into shell
There was a problem hiding this comment.
I think that this is fine as long we intend to keep these utils internal to Rancher Components.
rak-phillip
left a comment
There was a problem hiding this comment.
I left a few comments. I think the only item that we really need to address is the type casting.
I think this looks excellent and I hope that it will help to make our icon usage more consistent across the board.
There was a problem hiding this comment.
I think that this is fine as long we intend to keep these utils internal to Rancher Components.
Summary
Implements the RcIcon component of our Design System.
Technical notes summary
I did some refactoring so that our status color/design could more easily be reused.
Areas or cases that should be tested
The storybook for RcIcon, RcStatusBadge and RcStatusIndicator.
Areas which could experience regressions
See above
Screenshot/Video
Checklist
Admin,Standard UserandUser Base