Fix text selection in namespace filter input#16335
Merged
codyrancher merged 1 commit intorancher:masterfrom Jan 8, 2026
Merged
Fix text selection in namespace filter input#16335codyrancher merged 1 commit intorancher:masterfrom
codyrancher merged 1 commit intorancher:masterfrom
Conversation
The parent container's @mousedown.prevent was blocking text selection in the filter input. Adding @mousedown.stop to the input prevents the event from bubbling up, allowing normal text selection behavior while preserving the dropdown's focus management. Fixes rancher#12658
rak-phillip
approved these changes
Jan 8, 2026
Member
rak-phillip
left a comment
There was a problem hiding this comment.
LGTM - The change looks safe and is an improvement with regards to previous efforts to provide more consistent behavior in the NamespaceFilter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The parent container's @mousedown.prevent was blocking text selection in the filter input. Adding @mousedown.stop to the input prevents the event from bubbling up, allowing normal text selection behavior while preserving the dropdown's focus management.
Fixes #12658
Occurred changes and/or fixed issues
Users can now select text in the namespace filter input field using mouse interactions (double-click to select word, click-and-drag to select text).
Technical notes summary
This adds
@mousedown.stopon the input, preventing them from bubbling up to the parent.ns-filtercontainer where@mousedown.preventwould block text selection.Important: This change preserves the focus behavior fix introduced in ad2c555 (PR #11762).
Areas or cases that should be tested
Areas which could experience regressions
Checklist
Admin,Standard UserandUser Base