Skip to content

[16308][fleet][shell] Changed slideIn shellAPI to receive Props as a property inste…#16349

Merged
marcelofukumoto merged 3 commits intorancher:masterfrom
marcelofukumoto:16308-there-are-console-errors-in-the-fleet-dashboard-after-clicking-on-a-card-in-an-error-state
Jan 14, 2026
Merged

[16308][fleet][shell] Changed slideIn shellAPI to receive Props as a property inste…#16349
marcelofukumoto merged 3 commits intorancher:masterfrom
marcelofukumoto:16308-there-are-console-errors-in-the-fleet-dashboard-after-clicking-on-a-card-in-an-error-state

Conversation

@marcelofukumoto
Copy link
Copy Markdown
Contributor

@marcelofukumoto marcelofukumoto commented Jan 9, 2026

…ad to remove the wildcard from the root of the interface

Summary

Fixes #16308

Occurred changes and/or fixed issues

  • The resourceDetails slideIn stopped working after being changed to use the new ShellAPI
  • The problem is only on the call of the slideIn.open
  • To fix, just changed to send correctly
  • Additionally changed the interface to have props instead of allowing wild card, and allowing wild cards only inside props

Files changed:

  • shell/apis/intf/slide-in.ts - Changed the type to have the props instead of a wildcard
  • shell/apis/shell/tests/slide-in.test.ts - Added test for empty cases and the new props
  • shell/apis/shell/slide-in.ts - Configured to spread correctly, and remove the props after being removed to not spread
  • shell/pages/c/_cluster/fleet/index.vue - Added ts and changed the way it is being called

Technical notes summary

Areas or cases that should be tested

  • Click on fleet card of the dashboard should work now

Areas which could experience regressions

  • Any other place using the slideIn, but there is none now

Screenshot/Video

  • Working as intended now:
image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

…ad to remove the wildcard from the root of the interface
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.14.0 milestone Jan 9, 2026
@marcelofukumoto marcelofukumoto marked this pull request as ready for review January 9, 2026 17:27
Copy link
Copy Markdown
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Would you mind just updating the Shell package.json https://github.com/rancher/dashboard/blob/master/shell/package.json#L3 to 3.0.9-rc.1 so that it can be updated with this new signature, please?

I'll release it afterwards

@marcelofukumoto
Copy link
Copy Markdown
Contributor Author

Updated the version as requested!

Copy link
Copy Markdown
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mate!

@marcelofukumoto marcelofukumoto changed the title [16308] Changed slideIn shellAPI to receive Props as a property inste… [16308][fleet][shell] Changed slideIn shellAPI to receive Props as a property inste… Jan 13, 2026
@marcelofukumoto marcelofukumoto merged commit 057d09a into rancher:master Jan 14, 2026
63 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There are console errors in the Fleet dashboard after clicking on a card in an error state

2 participants