Skip to content

Add OIDC scopes from driver#16350

Merged
rak-phillip merged 5 commits intorancher:masterfrom
bartholdbos:fix-oidc-scopes
Feb 3, 2026
Merged

Add OIDC scopes from driver#16350
rak-phillip merged 5 commits intorancher:masterfrom
bartholdbos:fix-oidc-scopes

Conversation

@bartholdbos
Copy link
Copy Markdown
Contributor

@bartholdbos bartholdbos commented Jan 9, 2026

Summary

Fixes #16351

Occurred changes and/or fixed issues

Include OIDC scopes that are configured in Rancher in the request to the IdP

Technical notes summary

The frontend requests the authentication providers from the backend through the authproviders endpoint. This includes the scopes configured in Rancher user management. The frontend however did not include those scopes in the redirect url to the IdP

Areas or cases that should be tested

External authentication with OIDC

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Copy link
Copy Markdown
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartholdbos thanks for raising this PR. The change looks good, but unit tests are currently failing. It looks like we might require a mock for getAuthProvider with the relocation of the dispatch to fetch the driver.

@bartholdbos
Copy link
Copy Markdown
Contributor Author

@rak-phillip I'm not used to javascript and testing in javascript but I think I have passing unit tests now, if you have any review points please let me know

Copy link
Copy Markdown
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @bartholdbos thanks for the update, I think this looks great!

@rak-phillip rak-phillip merged commit 0d6ef8f into rancher:master Feb 3, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generic OIDC Group Scope is Not Being Sent Properly

3 participants