Add OIDC scopes from driver#16350
Merged
rak-phillip merged 5 commits intorancher:masterfrom Feb 3, 2026
Merged
Conversation
richard-cox
reviewed
Jan 9, 2026
rak-phillip
requested changes
Jan 21, 2026
Member
rak-phillip
left a comment
There was a problem hiding this comment.
@bartholdbos thanks for raising this PR. The change looks good, but unit tests are currently failing. It looks like we might require a mock for getAuthProvider with the relocation of the dispatch to fetch the driver.
Contributor
Author
|
@rak-phillip I'm not used to javascript and testing in javascript but I think I have passing unit tests now, if you have any review points please let me know |
rak-phillip
approved these changes
Feb 3, 2026
Member
rak-phillip
left a comment
There was a problem hiding this comment.
LGTM - @bartholdbos thanks for the update, I think this looks great!
9 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #16351
Occurred changes and/or fixed issues
Include OIDC scopes that are configured in Rancher in the request to the IdP
Technical notes summary
The frontend requests the authentication providers from the backend through the authproviders endpoint. This includes the scopes configured in Rancher user management. The frontend however did not include those scopes in the redirect url to the IdP
Areas or cases that should be tested
External authentication with OIDC
Areas which could experience regressions
Screenshot/Video
Checklist
Admin,Standard UserandUser Base