Sorting chart versions by momesgin · Pull Request #16384 · rancher/dashboard

momesgin · 2026-01-15T22:14:46Z

Summary

Occurred changes and/or fixed issues

We were relying on the order of the versions we received from the API but now we apply sorting to make sure the order is always correct.

Technical notes summary

Added compareChartVersions helper that uses semver library:
- It prioritizes standard semver comparison (semver.compare).
- If main versions are equal, it checks for Rancher's "up" build metadata (e.g., +upX.Y.Z). If found, it strips "up" and compares the inner versions recursively. This ensures ...-rc versions inside "up" are correctly treated as older than stable.
- As a fallback for other build metadata, it uses semver.compareBuild to sort alphabetically.
Updated shell/mixins/chart.js to use compareChartVersions for both sorting versions (mappedVersions) and determining the action(e.g. upgrade/downgrade...).
Removed isUpgradeFromPreToStable helper from utils/version.js as it is now covered by the new logic.
Expanded unit tests in shell/mixins/__tests__/chart.test.ts to cover various scenarios.

Areas or cases that should be tested

Chart Detail Page:
- Verify that the "Chart Versions" list is sorted in descending order (newest first).
- Check charts with mixed version types (stable, rc, alpha, beta, dev).
- Check charts with Rancher-specific "up" versions (e.g., Monitoring chart).
Upgrade/Downgrade Button:
- Install a pre-release version of a chart (e.g., ...-rc).
- Go to the detail page of the same chart. Select different versions and check if the button displays the correct wording(e.g. Upgrade.., Edit.., Downgrade...)

Areas which could experience regressions

Try installing charts with different types of versioning, like simple standard version, rc versions etc
On chart detail page make sure:
- the order of the versions is correct
- the button displays the correct wording(e.g. Upgrade.., Edit.., Downgrade...)
On the install page make sure:
- the order of versions is correct in the dropdown
- we display the correct wording(e.g. Upgrade.., Edit.., Downgrade...)

Screenshot/Video

Checklist

The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
The PR has a Milestone
The PR template has been filled out
The PR has been self reviewed
The PR has a reviewer assigned
The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
The PR has been reviewed in terms of Accessibility
The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Copilot

Pull request overview

This PR addresses incorrect version sorting for Helm charts by implementing a new compareChartVersions helper function that properly handles Rancher's special "up" build metadata and standard semver comparisons. The change fixes issue #14817 where release candidate versions were being displayed out of order on the chart detail page.

Changes:

Added compareChartVersions function to handle semver comparison with special logic for Rancher's "up" metadata
Updated chart version sorting in mappedVersions computed property and upgrade/downgrade action determination
Removed obsolete isUpgradeFromPreToStable helper function and its tests

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
shell/utils/chart.js	Added new `compareChartVersions` function with semver comparison and Rancher "up" metadata handling
shell/mixins/chart.js	Updated to use `compareChartVersions` for sorting versions and determining upgrade/downgrade actions
shell/utils/version.js	Removed obsolete `isUpgradeFromPreToStable` function
shell/utils/tests/version.test.ts	Removed tests for deleted `isUpgradeFromPreToStable` function
shell/mixins/tests/chart.test.ts	Added comprehensive test coverage for new sorting logic and action determination with various version formats

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

shell/utils/chart.js

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

shell/utils/chart.js

Copilot · 2026-01-16T01:03:45Z

shell/utils/chart.js

+ * @param {string} v2 - The second version string.
+ * @returns {number} - 0 if equal, -1 if v1 < v2, 1 if v1 > v2.
+ */
+export function compareChartVersions(v1, v2) {


The new compareChartVersions function lacks direct unit tests. While it's tested indirectly through the chart.test.ts tests for mappedVersions and action, consider adding dedicated unit tests in shell/utils/__tests__/chart.test.ts to cover edge cases such as null/undefined inputs, malformed versions, and various 'up' metadata patterns.

This one would be good to do. It's a granular function so having explicit tests for the issue would help

momesgin · 2026-01-16T19:53:25Z

@richard-cox I addressed the initial feedback from Copilot but then I mistakenly re-requested a review which caused it to came back with the current code change requests that I think are not necessary. Let me know what you think.

richard-cox

Just some minor tweaks needed.

FWIW i couldn't find any rancher or partner charts with RC now (that are applicable to the latest version of rancher). in the end i just used our rancher latest repo

richard-cox · 2026-02-02T16:25:37Z

shell/utils/chart.js

+ * @param {string} v2 - The second version string.
+ * @returns {number} - 0 if equal, -1 if v1 < v2, 1 if v1 > v2.
+ */
+export function compareChartVersions(v1, v2) {


This one would be good to do. It's a granular function so having explicit tests for the issue would help

shell/utils/chart.js

…-chart-versions

richard-cox · 2026-02-03T13:16:16Z

shell/utils/chart.js

+  let diff = semver.compare(v1, v2, { loose: true });
+
+  if (diff === 0) {
+    const vC = semver.parse(v1, { loose: true });


v + c are still used throughout this method, instead of v1 and v2

sorry I misread your earlier comment on this, done.

…-chart-versions

Mo Mesgin added 2 commits January 15, 2026 13:06

sorting versions of charts

3f09a52

lint

03c2e91

momesgin added this to the v2.14.0 milestone Jan 15, 2026

momesgin requested a review from Copilot January 15, 2026 22:14

momesgin self-assigned this Jan 15, 2026

momesgin added the QA/manual-test Indicates issue requires manually testing label Jan 15, 2026

Copilot started reviewing on behalf of momesgin January 15, 2026 22:15 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

shell/utils/chart.js Outdated Show resolved Hide resolved

shell/utils/chart.js Outdated Show resolved Hide resolved

fix edge case + update comment

d1e4fb1

momesgin requested a review from Copilot January 16, 2026 01:00

Copilot started reviewing on behalf of momesgin January 16, 2026 01:01 View session

momesgin requested a review from richard-cox January 16, 2026 01:01

Copilot AI reviewed Jan 16, 2026

View reviewed changes

momesgin changed the title ~~sorting versions of charts~~ Sorting chart versions Jan 22, 2026

resolve conflict

78ffae0

richard-cox reviewed Feb 2, 2026

View reviewed changes

Mo Mesgin added 2 commits February 2, 2026 12:01

Merge branch 'master' of github.com:rancher/dashboard into 14817-sort…

d199c2d

…-chart-versions

unit tests for compareChartVersions

5f0e333

momesgin requested a review from richard-cox February 3, 2026 04:24

richard-cox reviewed Feb 3, 2026

View reviewed changes

Mo Mesgin added 2 commits February 3, 2026 08:45

rename variables

a9a042d

Merge branch 'master' of github.com:rancher/dashboard into 14817-sort…

3fc11df

…-chart-versions

momesgin requested a review from richard-cox February 3, 2026 19:14

momesgin removed QA/manual-test Indicates issue requires manually testing labels Feb 4, 2026

richard-cox approved these changes Feb 9, 2026

View reviewed changes

momesgin merged commit d2b0090 into rancher:master Feb 9, 2026
117 of 122 checks passed

momesgin deleted the 14817-sort-chart-versions branch February 9, 2026 16:56

Conversation

momesgin commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

richard-cox Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

momesgin Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

momesgin commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richard-cox left a comment

Choose a reason for hiding this comment

Uh oh!

richard-cox Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

richard-cox Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

momesgin Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

momesgin commented Jan 15, 2026 •

edited

Loading

momesgin commented Jan 16, 2026 •

edited

Loading