Add PKCE method to OIDC auth providers#16392
Conversation
aalves08
left a comment
There was a problem hiding this comment.
Ok, spent quite a bit of time trying this and provisioning a new backend until I realised the backend PR is still a draft 🤦
Overall, LGTM. No red flags codewise. Would be nice to test it with the backend though... Let me know how you want to proceed.
FYI, I can't test keycloak OIDC anymore. My setup needs me to have an ngrok domain and we've hit the limit o max domains created for the whole ngrok account, so 🤷
|
@rak-phillip After security review, and some discussion we're going to drop support the |
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
The `plain` option will not be supported in Rancher, meaning that `S256` is the only supported option at this time. We can treat this as a toggle. Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
48da209 to
bb34474
Compare
aalves08
left a comment
There was a problem hiding this comment.
With the image you told me to use bigkevmcd/rancher:v2.14-29d9b6212-head, the feature doesn't work:
Screen.Recording.2026-01-27.at.11.24.22.mov
We dropped support for plain, but the field is still a string and not a boolean. Can we keep it as a string so that it's future-proofed against different PKCE verification algorithms (or the possible return of plain in the event that a customer needs it). |
@bigkevmcd the value is a string, the checkbox is there to act as a toggle for the feature. See
@aalves08 I'll try to gather some more info to see why it might be failing |
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
|
@aalves08 the |
|
I can also build a newer image...that is from a few weeks ago? |
@bigkevmcd yeah, that's the original image from when we first synced. |
There was a problem hiding this comment.
Testing with bigkevmcd/rancher:v2.14-29d9b6212-head
Still not working @rak-phillip ... When we do the action=configureTest the payload is sent correctly. Same for action=testAndApply but the returning cognito network requests from the server return with null.
Similar output with Keycloak.
Other topic, should we surface the PCKE information here, if it's active?
@aalves08 thanks for testing again - we have a new image that we can use to verify
That's a good point. I think we can add it. |
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
The original path was missing `oidc`, causing the lookup to fail Signed-off-by: Phillip Rak <rak.phillip@gmail.com>


Summary
This adds a new PKCE method input to the OIDC auth provider configuration.
Fixes #15637
Occurred changes and/or fixed issues
Technical notes summary
The PKCE method is being added to OIDC providers in rancher/rancher#53285. This PR addresses the UI portion for the new field.
During reviews of the form, we decided that the sections should be reordered to better emphasize importance for configuration.
Areas or cases that should be tested
OIDC configuration:
Areas which could experience regressions
This change is low risk. Configuration should still work in scenarios where the new option is not supported.
Screenshot/Video
Before
After
Checklist
Admin,Standard UserandUser Base