Set color of RcIcon to inherit if status prop is omitted#16432
Merged
rak-phillip merged 2 commits intorancher:masterfrom Jan 22, 2026
Merged
Set color of RcIcon to inherit if status prop is omitted#16432rak-phillip merged 2 commits intorancher:masterfrom
rak-phillip merged 2 commits intorancher:masterfrom
Conversation
The previous default of `no-color` produced a muted gray color that was low contrast and difficult to see in most cases. This updates the default color to inherit, so that the color of the icon will match the context that it is being used in without the need for the consumer to explicitly state the behavior. Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
48d75de to
fa7a0c4
Compare
codyrancher
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the default color to inherit, so that the color of the icon will match the context that it is being used in without the need for the consumer to explicitly state the behavior.
Occurred changes and/or fixed issues
Technical notes summary
The previous default of
no-colorproduced a muted gray color that was low contrast and difficult to see in most cases.Areas or cases that should be tested
Ensure that the status/colors of RcIcon behave like the did as before when a status prop is provided.
Ensure that the color defaults to inherit when a status prop is omitted.
Areas which could experience regressions
RcIcon default colors will change if no value for the status prop is provided. RcIcon isn't currently widely used, so the scope and impact of this change is small.
Screenshot/Video
NA
Checklist
Admin,Standard UserandUser Base