Skip to content

Set color of RcIcon to inherit if status prop is omitted#16432

Merged
rak-phillip merged 2 commits intorancher:masterfrom
rak-phillip:task/rc-icon-default-color
Jan 22, 2026
Merged

Set color of RcIcon to inherit if status prop is omitted#16432
rak-phillip merged 2 commits intorancher:masterfrom
rak-phillip:task/rc-icon-default-color

Conversation

@rak-phillip
Copy link
Copy Markdown
Member

@rak-phillip rak-phillip commented Jan 22, 2026

Summary

This updates the default color to inherit, so that the color of the icon will match the context that it is being used in without the need for the consumer to explicitly state the behavior.

Occurred changes and/or fixed issues

  • Set color of RcIcon to inherit if status prop is omitted

Technical notes summary

The previous default of no-color produced a muted gray color that was low contrast and difficult to see in most cases.

Areas or cases that should be tested

Ensure that the status/colors of RcIcon behave like the did as before when a status prop is provided.

Ensure that the color defaults to inherit when a status prop is omitted.

Areas which could experience regressions

RcIcon default colors will change if no value for the status prop is provided. RcIcon isn't currently widely used, so the scope and impact of this change is small.

Screenshot/Video

NA

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

The previous default of `no-color` produced a muted gray color that was low contrast and difficult to see in most cases. This updates the default color to inherit, so that the color of the icon will match the context that it is being used in without the need for the consumer to explicitly state the behavior.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@rak-phillip rak-phillip force-pushed the task/rc-icon-default-color branch from 48d75de to fa7a0c4 Compare January 22, 2026 17:39
@rak-phillip rak-phillip merged commit 99ecce5 into rancher:master Jan 22, 2026
88 of 93 checks passed
@rak-phillip rak-phillip deleted the task/rc-icon-default-color branch January 22, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants