Skip to content

Quote ssp filter values if they contain a -#16469

Merged
richard-cox merged 1 commit intorancher:masterfrom
richard-cox:fix-initial-hyphen
Jan 28, 2026
Merged

Quote ssp filter values if they contain a -#16469
richard-cox merged 1 commit intorancher:masterfrom
richard-cox:fix-initial-hyphen

Conversation

@richard-cox
Copy link
Copy Markdown
Member

Summary

Fixes #16454

Occurred changes and/or fixed issues

  • The UI will quote filter param values if they do not contain allowed chars
  • This was selectively done to keep the length of the url down
    • specifically for times when it grew on systems with lots of namespaces and global filters like Only User Namespaces were fetched
    • that process now uses IN/NOT IN args and doesn't use the quotes
  • Which means we can fix the issue of filter values starting with - failing by quoted them

Follows on from #14409

Areas or cases that should be tested

  • Free text filter in any list, deployments in upstream cluster with capi-controller-manager / -controller-manager is a good one

Areas which could experience regressions

  • Global header row user / system filters

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@richard-cox richard-cox added this to the v2.14.0 milestone Jan 26, 2026
@richard-cox richard-cox self-assigned this Jan 26, 2026
@richard-cox richard-cox merged commit 3b42311 into rancher:master Jan 28, 2026
64 of 66 checks passed
@richard-cox richard-cox deleted the fix-initial-hyphen branch January 28, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resource Table: Can not search with the - character

2 participants