Skip to content

Add editVersion translations for asyncButton and catalog#16530

Merged
momesgin merged 2 commits intorancher:masterfrom
EzraRT:master
Feb 2, 2026
Merged

Add editVersion translations for asyncButton and catalog#16530
momesgin merged 2 commits intorancher:masterfrom
EzraRT:master

Conversation

@EzraRT
Copy link
Copy Markdown
Contributor

@EzraRT EzraRT commented Feb 2, 2026

Summary

Fixes #16529

Occurred changes and/or fixed issues

Fixed a UI anomaly that occurred when updating the chart application using Chinese. Specifically:

  • Fixed a RangeError crash when attempting to downgrade an application in the zh-hans locale.
  • Added missing translation for the "managed application" warning banner.

Technical notes summary

The catalog.install.steps.basics.description key uses ICU Message Format's {action, select, ...} syntax. The zh-hans translation was missing the downgrade and editVersion options. When the UI attempted to render this string with action="downgrade", the formatter threw a RangeError because the case was unhandled.

Changes:

  • Added downgrade and editVersion to catalog.install.steps.basics.description in shell/assets/translations/zh-hans.yaml.
  • Added the missing catalog.install.warning.managed key to shell/assets/translations/zh-hans.yaml.

Areas or cases that should be tested

  1. Set the user preference Language to Chinese (Simplified).
  2. Navigate to Apps(应用) > Installed Apps(已安装的应用).
  3. Select an existing app and click Edit / Change Version.
  4. Select a version older than the current one to trigger the "downgrade" state.
  5. Verify that the page renders correctly without crashing.

Areas which could experience regressions

None expected. Changes are isolated to the zh-hans translation file and strictly add missing keys/options.

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@richard-cox richard-cox added this to the v2.14.0 milestone Feb 2, 2026
@momesgin
Copy link
Copy Markdown
Member

momesgin commented Feb 2, 2026

@EzraRT thanks for creating the issue and PR for this, I've found a couple of more missing translation key cases where we have the same type of select format.

@momesgin momesgin modified the milestone: v2.14.0 Feb 2, 2026
@momesgin momesgin merged commit 0fcbfc9 into rancher:master Feb 2, 2026
64 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When using Chinese, the chart's editVersion operation can cause an uncaught exception.

3 participants