Implement the list page for ext.cattle.io.kubeconfig#16555
Implement the list page for ext.cattle.io.kubeconfig#16555codyrancher merged 13 commits intorancher:masterfrom
ext.cattle.io.kubeconfig#16555Conversation
f314206 to
eb339c4
Compare
Replace Norman generateKubeconfig action with new ext.cattle.io.kubeconfig resource for download and copy operations. Update permission checks to use schema collectionMethods. Fixes rancher#13192
eb339c4 to
97ffe4d
Compare
ext.cattle.io.kubeconfig
…for the formatter.
rak-phillip
left a comment
There was a problem hiding this comment.
Looks good. I only have a few minor comments.
| @@ -0,0 +1,75 @@ | |||
| <script> | |||
There was a problem hiding this comment.
Why did we opt for javascript over typescript for this formatter?
There was a problem hiding this comment.
Just negligence. I think I didn't realize I left it js because the script portion of the file was so small.
Switched to TS.
| canViewProvClusters: !!this.$store.getters['management/canList'](CAPI.RANCHER_CLUSTER), | ||
| canViewMgmtClusters: !!this.$store.getters['management/canList'](MANAGEMENT.CLUSTER), |
There was a problem hiding this comment.
nit: canViewProvCluster and canViewMgmtClusters would be better served as computed props. Not only does the computed better map to a getter, it also expresses that we only expect to access these values.
There was a problem hiding this comment.
I also decided to switch this (and the formatter) over to the composable API. I had just used one of the existing list views as a template instead of starting from scratch.
|
|
||
| data() { | ||
| return { | ||
| resource: (EXT as any).KUBECONFIG, |
There was a problem hiding this comment.
Yeah, left over from prior to converting it to using the ssp component. Removed.
Summary
Fixes #14911
Occurred changes and/or fixed issues
Technical notes summary
+ {remainingCount} moreAreas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
kube-list.mp4
We will show an ellipsis if we overflow.

Checklist
Admin,Standard UserandUser Base