Skip to content

[12941] Added banner for when url is https://github.com and auth is basic#16575

Merged
marcelofukumoto merged 5 commits intorancher:masterfrom
marcelofukumoto:12941-fleet-git-repos-github-password-field-should-be-renamed-to-personal-account-token
Feb 13, 2026
Merged

[12941] Added banner for when url is https://github.com and auth is basic#16575
marcelofukumoto merged 5 commits intorancher:masterfrom
marcelofukumoto:12941-fleet-git-repos-github-password-field-should-be-renamed-to-personal-account-token

Conversation

@marcelofukumoto
Copy link
Copy Markdown
Contributor

@marcelofukumoto marcelofukumoto commented Feb 5, 2026

Summary

Fixes #12941

Occurred changes and/or fixed issues

  • Added a new banner for when URL is https://github.com (no case sensitive) and BASIC auth.
  • It should show mostly on EDIT/CREATE because it is when you can select, there is no rule for VIEW but should not show because the selected will be an auth already.

Technical notes summary

  • Only github.com would have that logic clearly.
  • No changes to the input since as a secret the name of the input is still PASSWORD

Areas or cases that should be tested

  • CREATE/EDIT/VIEW GitRepo with the HTTP selected - should show
  • CREATE/EDIT/VIEW GitRepo with the SSH selected - should not show
  • CREATE/EDIT/VIEW HelmOps - Should not show

Areas which could experience regressions

  • CREATE/EDIT/VIEW GitRepo

Screenshot/Video

image image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@marcelofukumoto marcelofukumoto marked this pull request as ready for review February 9, 2026 10:23
…d-should-be-renamed-to-personal-account-token
Copy link
Copy Markdown
Member

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelofukumoto marcelofukumoto merged commit 603dfcc into rancher:master Feb 13, 2026
118 of 122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fleet: Git repos github password field should be renamed to personal account token

2 participants