replace creation of tokens from Norman to Steve#16674
Merged
aalves08 merged 11 commits intorancher:masterfrom Feb 20, 2026
Merged
replace creation of tokens from Norman to Steve#16674aalves08 merged 11 commits intorancher:masterfrom
aalves08 merged 11 commits intorancher:masterfrom
Conversation
richard-cox
reviewed
Feb 16, 2026
rak-phillip
reviewed
Feb 17, 2026
3140632 to
bc718dd
Compare
rak-phillip
previously approved these changes
Feb 18, 2026
3f0d9fd to
ab980f2
Compare
richard-cox
reviewed
Feb 19, 2026
Member
richard-cox
left a comment
There was a problem hiding this comment.
Definitely worth updating the tests / regression test. Would also be good to show some examples on how to validate that the tokens work (if you create a token, copy any curl request the ui makes when logged in, change the url to just something somple like /v1/pods and swap in the auth bearer token we suggest).
We also might need to pivot on the message, i don't think the deprecation of v3/tokens has been announced. visually it might need to be "legacy" and we tone down the warning message
ab980f2 to
13fb18e
Compare
richard-cox
reviewed
Feb 20, 2026
Member
richard-cox
left a comment
There was a problem hiding this comment.
some tweaks required around deprecated + legacy, and some questions on the new max/ttl handling
…ngs-p2 server-url
richard-cox
reviewed
Feb 20, 2026
richard-cox
approved these changes
Feb 20, 2026
Member
richard-cox
left a comment
There was a problem hiding this comment.
This one needs a squash merge
richard-cox
added a commit
to richard-cox/dashboard
that referenced
this pull request
Mar 17, 2026
This reverts commit 05ded50.
richard-cox
added a commit
to richard-cox/dashboard
that referenced
this pull request
Mar 17, 2026
This reverts commit 05ded50.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12332
Occurred changes and/or fixed issues
Technical notes summary
NORMAN.TOKENbecause the table we will display is a mashup of both token typesenabledordisabledwhen creating oneshell/models/ext.cattle.io.token.jshad to define some new properties that at first glance my be reductant but they allow us to make it compatible with the oldNORMAN.TOKENheaders so that table values for the new token are populated/displayed correctlyinactiveas now a new token can be enabled or disabledAccount and API Keyspage above the table with a deprecation notice IF there are old token entries displayedAreas or cases that should be tested
Areas which could experience regressions
neveronly works if max TTL is set to < 0 (updated the UI accordingly, also with banner message to explain to user)Screenshot/Video
Checklist
Admin,Standard UserandUser Base