Skip to content

replace creation of tokens from Norman to Steve#16674

Merged
aalves08 merged 11 commits intorancher:masterfrom
aalves08:12332-ext-tokens
Feb 20, 2026
Merged

replace creation of tokens from Norman to Steve#16674
aalves08 merged 11 commits intorancher:masterfrom
aalves08:12332-ext-tokens

Conversation

@aalves08
Copy link
Copy Markdown
Member

@aalves08 aalves08 commented Feb 16, 2026

Summary

Fixes #12332

Occurred changes and/or fixed issues

  • Replace creation of tokens from Norman to Steve

Technical notes summary

  • moved headers to the actual template file since we now lose the configuration of headers for NORMAN.TOKEN because the table we will display is a mashup of both token types
  • added UI option to set token as enabled or disabled when creating one
  • in shell/models/ext.cattle.io.token.js had to define some new properties that at first glance my be reductant but they allow us to make it compatible with the old NORMAN.TOKEN headers so that table values for the new token are populated/displayed correctly
  • incorporated new state inactive as now a new token can be enabled or disabled
  • added banner to Account and API Keys page above the table with a deprecation notice IF there are old token entries displayed

Areas or cases that should be tested

Areas which could experience regressions

  • option never only works if max TTL is set to < 0 (updated the UI accordingly, also with banner message to explain to user)

Screenshot/Video

Screenshot 2026-02-20 at 11 12 08 Screenshot 2026-02-20 at 11 10 04 Screenshot 2026-02-20 at 11 10 01

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@aalves08 aalves08 added this to the v2.14.0 milestone Feb 16, 2026
@aalves08 aalves08 self-assigned this Feb 16, 2026
rak-phillip
rak-phillip previously approved these changes Feb 18, 2026
Copy link
Copy Markdown
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely worth updating the tests / regression test. Would also be good to show some examples on how to validate that the tokens work (if you create a token, copy any curl request the ui makes when logged in, change the url to just something somple like /v1/pods and swap in the auth bearer token we suggest).

We also might need to pivot on the message, i don't think the deprecation of v3/tokens has been announced. visually it might need to be "legacy" and we tone down the warning message

Copy link
Copy Markdown
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some tweaks required around deprecated + legacy, and some questions on the new max/ttl handling

@aalves08 aalves08 requested a review from richard-cox February 20, 2026 16:37
Copy link
Copy Markdown
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one needs a squash merge

@aalves08 aalves08 merged commit 05ded50 into rancher:master Feb 20, 2026
67 of 68 checks passed
richard-cox added a commit to richard-cox/dashboard that referenced this pull request Mar 17, 2026
richard-cox added a commit to richard-cox/dashboard that referenced this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Power API Keys list with new ext.cattle.io.tokens

3 participants