Skip to content

block editing v2 prov capi clusters#16711

Merged
richard-cox merged 7 commits intorancher:masterfrom
mantis-toboggan-md:16679-v2prov-capi
Feb 23, 2026
Merged

block editing v2 prov capi clusters#16711
richard-cox merged 7 commits intorancher:masterfrom
mantis-toboggan-md:16679-v2prov-capi

Conversation

@mantis-toboggan-md
Copy link
Copy Markdown
Member

@mantis-toboggan-md mantis-toboggan-md commented Feb 19, 2026

Summary

Fixes #16679

Occurred changes and/or fixed issues

  • remove provisioning cluster list detail links
  • remove view config, edit config options
  • remove snapshot, restore snapshot, rotate certs, rotate encryption key, autoscaler actions
  • remove machine provider display
  • add message about detail/edit being disabled to the provisioning cluster list, alongside any error messages

Screenshot/Video

Screenshot 2026-02-19 at 1 14 28 PM Screenshot 2026-02-19 at 1 17 34 PM

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements UI restrictions for v2 provisioning CAPI clusters that were created using upstream CAPI infrastructure providers instead of Rancher's machine providers. These clusters cannot be edited through the Rancher UI and require special handling.

Changes:

  • Added isCapiHybrid getter to identify clusters using upstream CAPI infrastructure providers
  • Disabled editing capabilities (detail links, edit config, snapshots, rotate certificates/encryption keys, autoscaler actions)
  • Added warning message to cluster list indicating these clusters cannot be modified through the UI
  • Hidden machine provider display for CAPI hybrid clusters
  • Added comprehensive test coverage with mocked CAPI cluster data

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
shell/models/provisioning.cattle.io.cluster.js Added isCapiHybrid getter and integrated checks throughout permission and action methods to disable editing for CAPI hybrid clusters
shell/list/provisioning.cattle.io.cluster.vue Added getCustomDetailLink method to disable detail page navigation for CAPI hybrid clusters
shell/components/formatter/ClusterLink.vue Added getCustomDetailLink prop support to allow custom link resolution logic
shell/components/SortableTable/index.vue Changed to use v-clean-html directive for rendering state descriptions that may contain HTML
shell/assets/translations/en-us.yaml Added warning message for CAPI clusters that cannot be modified through UI
cypress/e2e/tests/pages/manager/v2prov-capi.spec.ts Added test suite verifying CAPI hybrid cluster restrictions
cypress/e2e/po/components/list-row.po.ts Added description() method to access state description rows in tests
cypress/e2e/blueprints/manager/v2prov-capi-cluster-mocks.ts Added mock data for provisioning and management CAPI clusters

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mantis-toboggan-md
Copy link
Copy Markdown
Member Author

Updated to use additional-sub-rows instead of a new sortabletable slot. I backed out changes to sortabletable and got rid of the stateDescription hack I commented on above

Screenshot 2026-02-20 at 9 04 24 AM Screenshot 2026-02-20 at 9 10 46 AM Screenshot 2026-02-20 at 9 13 26 AM Screenshot 2026-02-20 at 9 13 32 AM Screenshot 2026-02-20 at 9 13 48 AM Screenshot 2026-02-20 at 9 13 42 AM

Copy link
Copy Markdown
Member

@momesgin momesgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

:colspan="fullColspan - (tableActions ? 1: 0)"
>
<div
class="text-error"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we tweak this change in the future we should consider dropping this to a warning

Copy link
Copy Markdown
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to go with Mo's main review. I haven't tested, but visually checked PR. One minor comment if we change something in the future.

Also discussed this generally with Neil and we're happy for this to merge and make any changes separately.

@richard-cox richard-cox merged commit 57ce2cc into rancher:master Feb 23, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v2.14] Handle v2prov CAPI clusters provisioned outside of the UI

4 participants