Skip to content

Fixed Ingress banner wrongfully shown on edit#16830

Merged
eva-vashkevich merged 1 commit intorancher:masterfrom
eva-vashkevich:fix_ingress_banner
Mar 4, 2026
Merged

Fixed Ingress banner wrongfully shown on edit#16830
eva-vashkevich merged 1 commit intorancher:masterfrom
eva-vashkevich:fix_ingress_banner

Conversation

@eva-vashkevich
Copy link
Copy Markdown
Member

@eva-vashkevich eva-vashkevich commented Mar 4, 2026

Summary

Fixes #15950

Fixed "Before switching to Traefik, please review our migration documentation Opens in a new tabto ensure your Ingress resources are updated to support Traefik’s configuration requirements." warning banner appearing on cluster creation.

Occurred changes and/or fixed issues

There was a typo in isEdit making the check wrong.

Technical notes summary

Areas or cases that should be tested

Go to create an RKE2 cluster -> Ingress
Switch between nginx and traefik a few times. the warning banner should not appear under the ingress selection cards.
It should till appear when switcihng between selections on edit.

Areas which could experience regressions

None

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the ingress migration warning banner being shown during RKE2 cluster creation by correcting the edit-mode check so the banner logic only triggers when editing an existing cluster.

Changes:

  • Fixes the isEdit check in the ingress selection handler by using the computed value (isEdit.value) instead of the computed ref object.
  • Prevents the Traefik migration banner from being incorrectly triggered in create mode when switching ingress selections.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@eva-vashkevich eva-vashkevich merged commit 91fa814 into rancher:master Mar 4, 2026
77 of 89 checks passed
@eva-vashkevich eva-vashkevich deleted the fix_ingress_banner branch March 4, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Traefik to be selected as ingress controller for RKE2 via Rancher UI

3 participants