Fixed Ingress banner wrongfully shown on edit#16830
Merged
eva-vashkevich merged 1 commit intorancher:masterfrom Mar 4, 2026
Merged
Fixed Ingress banner wrongfully shown on edit#16830eva-vashkevich merged 1 commit intorancher:masterfrom
eva-vashkevich merged 1 commit intorancher:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the ingress migration warning banner being shown during RKE2 cluster creation by correcting the edit-mode check so the banner logic only triggers when editing an existing cluster.
Changes:
- Fixes the
isEditcheck in the ingress selection handler by using the computed value (isEdit.value) instead of the computed ref object. - Prevents the Traefik migration banner from being incorrectly triggered in create mode when switching ingress selections.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
momesgin
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15950
Fixed "Before switching to Traefik, please review our migration documentation Opens in a new tabto ensure your Ingress resources are updated to support Traefik’s configuration requirements." warning banner appearing on cluster creation.
Occurred changes and/or fixed issues
There was a typo in isEdit making the check wrong.
Technical notes summary
Areas or cases that should be tested
Go to create an RKE2 cluster -> Ingress
Switch between nginx and traefik a few times. the warning banner should not appear under the ingress selection cards.
It should till appear when switcihng between selections on edit.
Areas which could experience regressions
None
Screenshot/Video
Checklist
Admin,Standard UserandUser Base