Skip to content

Fixed harvester chart values not being set#16850

Merged
eva-vashkevich merged 1 commit intorancher:masterfrom
eva-vashkevich:iss10123-harvester
Mar 5, 2026
Merged

Fixed harvester chart values not being set#16850
eva-vashkevich merged 1 commit intorancher:masterfrom
eva-vashkevich:iss10123-harvester

Conversation

@eva-vashkevich
Copy link
Copy Markdown
Member

@eva-vashkevich eva-vashkevich commented Mar 5, 2026

Summary

Fixes #16857

As part of Traefik changes, I broke the logic around updating charts. This change revert it to the previous state.

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Attempt to provision a harvester cluster.
Validate that request contains 'harvester-cloud-provider' configuration under spec.rkeConfig.chartValues

Areas which could experience regressions

RKE2 and K3s provisioning could be affected. In particular, recently added Ingress configuration

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a regression in the Harvester cluster provisioning flow where chart values (e.g., harvester-cloud-provider) were not being set in spec.rkeConfig.chartValues. The bug was introduced during Traefik-related changes that incorrectly replaced direct property assignments with Vue 2-style reactive setters (this.set()), which inadvertently broke the chart values update logic.

Changes:

  • Replaces Object.keys(this.versionInfo).forEach((key) => delete this.versionInfo[key]) with a simpler this.versionInfo = {} for clearing the version info cache on Kubernetes version change.
  • Replaces this.set(this.versionInfo, chartName, res), this.set(this.userChartValues, key, {}), and this.set(this.userChartValues, key, different) with direct property assignments, matching the pre-regression behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@a110605
Copy link
Copy Markdown
Member

a110605 commented Mar 5, 2026

Tested on new created cluster. The LB creation flow is good.

Test Steps:

  1. Import a harvester into rancher (1.7.x or 1.8.0 is fine)
  2. Create a downstream harvester cluster
  3. Go to Cluster -> Worload -> Deployment, create a nginx pod (container image : nginx:latest)
image 4. Add label `name: mynginx` in that pod image
  1. Go to Service Discovery -> Service - > Create
  • Service port : myport / 8080 / 80
  • Selector : name / mynginx
  1. The LB should be successfully created.
Screenshot 2026-03-05 at 5 03 58 PM Screenshot 2026-03-05 at 5 04 04 PM

Copy link
Copy Markdown
Member

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eva-vashkevich eva-vashkevich merged commit b423181 into rancher:master Mar 5, 2026
80 of 101 checks passed
@eva-vashkevich eva-vashkevich deleted the iss10123-harvester branch March 5, 2026 18:35
nwmac added a commit to nwmac/dashboard that referenced this pull request Mar 9, 2026
* Fixed harvester chart values not being set (rancher#16850)

* Removing the state column from the kubeconfig list page

Fixes rancher#16842

* Update GH Workflows (rancher#16879)

* Update GH Workflows

* Add in improvement to e2e test

* Re-introduce GitHub Project Integration

* For testing

---------

Co-authored-by: Evgeniya Vashkevich <evgeniya.vashkevich@suse.com>
Co-authored-by: Cody Jackson <cody.jackson@suse.com>
Co-authored-by: Richard Cox <18697775+richard-cox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Harvester provisioning is broken after the Traefik changes

4 participants