Fixed harvester chart values not being set#16850
Merged
eva-vashkevich merged 1 commit intorancher:masterfrom Mar 5, 2026
Merged
Fixed harvester chart values not being set#16850eva-vashkevich merged 1 commit intorancher:masterfrom
eva-vashkevich merged 1 commit intorancher:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression in the Harvester cluster provisioning flow where chart values (e.g., harvester-cloud-provider) were not being set in spec.rkeConfig.chartValues. The bug was introduced during Traefik-related changes that incorrectly replaced direct property assignments with Vue 2-style reactive setters (this.set()), which inadvertently broke the chart values update logic.
Changes:
- Replaces
Object.keys(this.versionInfo).forEach((key) => delete this.versionInfo[key])with a simplerthis.versionInfo = {}for clearing the version info cache on Kubernetes version change. - Replaces
this.set(this.versionInfo, chartName, res),this.set(this.userChartValues, key, {}), andthis.set(this.userChartValues, key, different)with direct property assignments, matching the pre-regression behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
richard-cox
reviewed
Mar 5, 2026
Member
nwmac
added a commit
to nwmac/dashboard
that referenced
this pull request
Mar 9, 2026
* Fixed harvester chart values not being set (rancher#16850) * Removing the state column from the kubeconfig list page Fixes rancher#16842 * Update GH Workflows (rancher#16879) * Update GH Workflows * Add in improvement to e2e test * Re-introduce GitHub Project Integration * For testing --------- Co-authored-by: Evgeniya Vashkevich <evgeniya.vashkevich@suse.com> Co-authored-by: Cody Jackson <cody.jackson@suse.com> Co-authored-by: Richard Cox <18697775+richard-cox@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
Fixes #16857
As part of Traefik changes, I broke the logic around updating charts. This change revert it to the previous state.
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Attempt to provision a harvester cluster.
Validate that request contains 'harvester-cloud-provider' configuration under spec.rkeConfig.chartValues
Areas which could experience regressions
RKE2 and K3s provisioning could be affected. In particular, recently added Ingress configuration
Screenshot/Video
Checklist
Admin,Standard UserandUser Base