Fix use_proxy? to correctly handle IPv6 addresses in no_proxy#219
Open
rodrigotomonari wants to merge 1 commit intoruby:masterfrom
Open
Fix use_proxy? to correctly handle IPv6 addresses in no_proxy#219rodrigotomonari wants to merge 1 commit intoruby:masterfrom
rodrigotomonari wants to merge 1 commit intoruby:masterfrom
Conversation
The previous regex-based scan fragmented IPv6 addresses on colons, causing all IPv6 no_proxy entries to be silently ignored. Replace scan with split-then-branch parsing that handles four formats: - Bare IPv6: 2001:db8::1, 2001:db8::/32 - Bracketed: [2001:db8::1] - Bracketed with port: [2001:db8::1]:8080 - IPv4/hostname: example.com, 10.0.0.1:8080, example.com: (trailing colon) Also strips zone IDs (e.g. ::1%eth0) before IPAddr matching, and reads $2 before calling sub() to avoid global match variable clobbering. Fixes ruby#218
rodrigotomonari
commented
Apr 6, 2026
| begin | ||
| return false if IPAddr.new(p_host).include?(addr) | ||
| rescue IPAddr::InvalidAddressError | ||
| next |
Author
There was a problem hiding this comment.
The next in the rescue IPAddr::InvalidAddressError clause was removed as it is redundant. Falling off the end of the block body advances to the next iteration identically to calling next explicitly. No behavioral change.
|
@hsbt Would you mind taking a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous regex-based scan fragmented IPv6 addresses on colons, causing all IPv6 no_proxy entries to be silently ignored.
Replace scan with split-then-branch parsing that handles four formats:
Also strips zone IDs (e.g. ::1%eth0) before IPAddr matching, and reads $2 before calling sub() to avoid global match variable clobbering.
Fixes #218