Fix axes mismatch when elements have multi-CS transformations#580
Merged
Fix axes mismatch when elements have multi-CS transformations#580
Conversation
timtreis
force-pushed
the
fix/issue-176-multi-cs-ax-mismatch
branch
from
cf34bfe to
3961712
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
==========================================
+ Coverage 75.36% 75.63% +0.26%
==========================================
Files 10 10
Lines 2935 2996 +61
Branches 684 702 +18
==========================================
+ Hits 2212 2266 +54
- Misses 441 444 +3
- Partials 282 286 +4
🚀 New features to boost your workflow:
|
When elements have transformations to multiple coordinate systems, filter_by_coordinate_system cannot strip the extra transformations (upstream limitation). This caused show() to auto-detect too many CS and raise a mismatch error when the user passed their own axes. Apply a stricter CS filter when coordinate_systems is auto-detected and axes are provided: keep only CS that have element types for all render commands. Also improve the error message with a hint to pass coordinate_systems= explicitly when the mismatch cannot be resolved. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
timtreis
force-pushed
the
fix/issue-176-multi-cs-ax-mismatch
branch
from
3961712 to
113aa11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filter_by_coordinate_systemcan't strip extra transformations (upstream limitation), causingshow()to detect too many CS and raise a mismatch error when the user passes their own axes.coordinate_systemsis auto-detected andaxis provided, applies a stricter CS filter: keeps only CS that have element types for all render commands. Falls back to aValueErrorwith a helpful hint if the mismatch can't be resolved.figfrom axes instead of requiring it).