Skip to content

fix: specify authTagLength in AES-GCM createDecipheriv calls #3881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NLmejiro wants to merge 1 commit into from
Closed

fix: specify authTagLength in AES-GCM createDecipheriv calls #3881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/sim/lib/api-key/crypto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export async function decryptApiKey(encryptedValue: string): Promise<{ decrypted
const authTag = Buffer.from(authTagHex, 'hex')

try {
const decipher = createDecipheriv('aes-256-gcm', key, iv)
const decipher = createDecipheriv('aes-256-gcm', key, iv, { authTagLength: 16 })
decipher.setAuthTag(authTag)

let decrypted = decipher.update(encrypted, 'hex', 'utf8')
Expand Down
2 changes: 1 addition & 1 deletion apps/sim/lib/core/security/encryption.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export async function decryptSecret(encryptedValue: string): Promise<{ decrypted
const authTag = Buffer.from(authTagHex, 'hex')

try {
const decipher = createDecipheriv('aes-256-gcm', key, iv)
const decipher = createDecipheriv('aes-256-gcm', key, iv, { authTagLength: 16 })
decipher.setAuthTag(authTag)

let decrypted = decipher.update(encrypted, 'hex', 'utf8')
Expand Down
2 changes: 1 addition & 1 deletion packages/db/scripts/migrate-block-api-keys-to-byok.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ async function decryptSecret(encryptedValue: string): Promise<string> {
const iv = Buffer.from(ivHex, 'hex')
const authTag = Buffer.from(authTagHex, 'hex')

const decipher = createDecipheriv('aes-256-gcm', key, iv)
const decipher = createDecipheriv('aes-256-gcm', key, iv, { authTagLength: 16 })
decipher.setAuthTag(authTag)

let decrypted = decipher.update(encrypted, 'hex', 'utf8')
Expand Down