feat(triggers): add Salesforce webhook triggers#3982
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Registers these triggers in Reviewed by Cursor Bugbot for commit d67ab32. Configure here. |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
Greptile SummaryThis PR adds 6 Salesforce webhook triggers (record created/updated/deleted, opportunity stage changed, case status changed, and a generic catch-all) following the established pattern used by Lemlist, Cal.com, and Confluence integrations. The code is well-structured with shared utilities in Two P2 UX issues were found in
Confidence Score: 5/5Safe to merge — functionally correct code that follows established patterns; only P2 UX/documentation issues remain Both findings are P2 issues in setup instruction text and output schema semantics that do not affect runtime behavior or data integrity. All 6 triggers are correctly registered, the block wiring is correct, and the code structure mirrors proven existing integrations. apps/sim/triggers/salesforce/utils.ts — incorrect Flow trigger condition names for Opportunity Stage Changed and Case Status Changed, and changedFields on created/deleted outputs Important Files Changed
Sequence DiagramsequenceDiagram
participant SF as Salesforce Flow
participant WH as Sim Webhook Endpoint
participant TR as Trigger Registry
participant WF as Workflow Engine
SF->>WH: POST /webhook/{path}<br/>(JSON: eventType, objectType, record, ...)
WH->>TR: Lookup TriggerConfig by triggerId
Note over TR: salesforce_record_created<br/>salesforce_record_updated<br/>salesforce_record_deleted<br/>salesforce_opportunity_stage_changed<br/>salesforce_case_status_changed<br/>salesforce_webhook
TR-->>WH: TriggerConfig (outputs schema)
WH->>WF: Execute workflow with mapped outputs
WF-->>SF: 200 OK
Reviews (2): Last reviewed commit: "fix(triggers): address PR review — remov..." | Re-trigger Greptile |
8f1efd8 to
ce78227
Compare
…ric webhook instructions
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d67ab32. Configure here.
* feat(triggers): add Salesforce webhook triggers * fix(triggers): address PR review — remove non-TSDoc comment, fix generic webhook instructions
* feat(triggers): add Salesforce webhook triggers * fix(triggers): address PR review — remove non-TSDoc comment, fix generic webhook instructions
Summary
Type of Change
Testing
Tested manually
Checklist