Closed
Conversation
fpistm
requested changes
Jan 12, 2026
github-project-automation
bot
moved this from In progress
to Needs review
in STM32 core based on ST HAL
fpistm
requested changes
Jan 13, 2026
Member
fpistm
left a comment
fpistm
left a comment
There was a problem hiding this comment.
pay attention to kept as mush as possible original code.
Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
Ref: arduino#242 Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
- Change pulseIn and pulseInLong prototypes from uint8_t pin to pin_size_t pin. Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
Aymane-ST
force-pushed
the
dev
branch
3 times, most recently
from
4ddffe6 to
99e54cc
Compare
- Add float overloads to Print::print/println - Enhance Print with printf() and vprintf() helpers Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
SPISettings was originally implemented with init_AlwaysInline / init_MightInline helpers, using runtime initialization only. This change: - removes init_AlwaysInline / init_MightInline helpers, - replaces them with constexpr constructors that directly initialize the members, - keeps the existing API surface refs: stm32duino/Arduino_Core_STM32#2204 stm32duino/Arduino_Core_STM32#2201
fpistm
reviewed
Apr 7, 2026
github-project-automation
bot
moved this from Needs review
to Done
in STM32 core based on ST HAL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the effort to rework ArduinoCore-API so it can be used as a git submodule in STM32duino’s Arduino_Core_STM32.
The changes in this branch: