Skip to content

Fail on new UB in CI#148168

Open
StanFromIreland wants to merge 9 commits intopython:mainfrom
StanFromIreland:san-ubsan
Open

Fail on new UB in CI#148168
StanFromIreland wants to merge 9 commits intopython:mainfrom
StanFromIreland:san-ubsan

Conversation

@StanFromIreland
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland commented Apr 6, 2026

Trying to debug a bit, it should be detecting #148166 (and also screaming about it), but it isn't. Mirroring what we do for the TSan job.

Just chucked everything in suppressions for now, they should be reviewed as it may have actual bugs.

@StanFromIreland StanFromIreland changed the title Fail on new UB Fail on new UB in CI Apr 6, 2026
@StanFromIreland
Copy link
Copy Markdown
Member Author

I've never been so happy to see the CI fail :-)

[3](https://github.com/python/cpython/actions/runs/24037637122/job/70101135069?pr=148168#step:11:144)
==> /home/runner/work/cpython/cpython/san_log.26255 <==
Modules/binascii.c:1243:42: runtime error: left shift of 129 by 24 places cannot be represented in type 'int'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Modules/binascii.c:1243:42

@thesamesam
Copy link
Copy Markdown
Contributor

We got there in the end: #111758 (comment) :)

I'd assumed that #135578 or #136820 included that but I didn't check.

@StanFromIreland StanFromIreland marked this pull request as ready for review April 6, 2026 16:16
@StanFromIreland StanFromIreland marked this pull request as draft April 6, 2026 16:19
@StanFromIreland StanFromIreland marked this pull request as ready for review April 6, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants