GH-111758: Merge TSan and UBSan reusable GHA workflows by webknjaz · Pull Request #136820 · python/cpython

webknjaz · 2025-07-19T14:11:23Z

This patch deduplicates the contents of reusable-tsan.yml and reusable-ubsan.yml, making them one. The new workflow replaces the duplicated ones in the top-level build.yml and are called with different sanitizer parameters.

It is based on Hugo's patch. Context:

Issue: CI should run Undefined Behavior Sanitizer (UBSAN), as already done for ASAN #111758

.github/workflows/reusable-san.yml

webknjaz · 2025-07-19T14:55:24Z

.github/workflows/reusable-ubsan.yml

Note
Prior to this PR, this workflow wasn't contributing to the branch protection status. Once it's merged, it'll fail the PRs if something crashes.

.github/workflows/build.yml

webknjaz · 2025-07-19T14:56:58Z

.github/workflows/reusable-san.yml

-  build-tsan-reusable:
-    name: 'Thread sanitizer'
+  build-san-reusable:
+    name: ${{ inputs.sanitizer }}


Per discussion w/ Hugo, this needs to mention the FT flag.

.github/workflows/reusable-san.yml

Co-Authored-By: Sviatoslav Sydorenko <webknjaz@redhat.com>

.github/workflows/reusable-san.yml

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

webknjaz · 2025-07-20T17:45:41Z

@hugovk I think this needs backport labels to keep the CI in other branches close.

hugovk

Thank you, this also nicely groups the jobs under a single collapsible thingy 👍

Before:

and:

After:

and:

miss-islington-app · 2025-07-20T20:03:50Z

Thanks @webknjaz for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

…H-136820) (cherry picked from commit 65d2c51) Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

miss-islington-app · 2025-07-20T20:04:02Z

Sorry, @webknjaz and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 65d2c51c10425dcfacc0a13810d58c41240d7ff9 3.13

bedevere-app · 2025-07-20T20:04:06Z

GH-136883 is a backport of this pull request to the 3.14 branch.

) (#136883) Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

hugovk · 2025-07-20T21:10:39Z

@hugovk I think this needs backport labels to keep the CI in other branches close.

Hmm, we didn't have UBSan in the 3.14 branch yet. I'm fine with having it there (and 3.13), but also to revert #136883 if it's not necessary to backport.

@encukou Should we have this just in main, or also backport?

webknjaz · 2025-07-20T21:33:25Z

but also to revert #136883 if it's not necessary to backport.

I'd suggest reverting partially if needed, but the job grouping and generalization are good to keep.

encukou · 2025-07-21T13:47:36Z

@hugovk ultimately up to you, but, if it works on 3.14 I think we should keep it working.
Not on 3.13 though -- we'd need to backport #111178 to make UBSan pass.

…ython#136820) (cherry picked from commit 65d2c51) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>

bedevere-app · 2025-07-23T02:36:14Z

GH-137029 is a backport of this pull request to the 3.13 branch.

… (GH-137029) (cherry picked from commit 65d2c51) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>

…136820) Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

…ythonGH-136820) (python#136883) Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

bedevere-app bot mentioned this pull request Jul 19, 2025

CI should run Undefined Behavior Sanitizer (UBSAN), as already done for ASAN #111758

Closed

StanFromIreland added the skip news label Jul 19, 2025

webknjaz commented Jul 19, 2025

View reviewed changes

.github/workflows/reusable-san.yml Show resolved Hide resolved

webknjaz commented Jul 19, 2025

View reviewed changes

.github/workflows/reusable-san.yml Outdated Show resolved Hide resolved

webknjaz commented Jul 19, 2025

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

webknjaz commented Jul 19, 2025

View reviewed changes

.github/workflows/reusable-san.yml Outdated Show resolved Hide resolved

webknjaz force-pushed the maintenance/111758-gha-combined-san branch 2 times, most recently from 8592567 to 115b8e3 Compare July 20, 2025 09:33

hugovk and others added 2 commits July 20, 2025 12:51

Merge reusable-tsan.yml and reusable-ubsan.yml

8332820

Co-Authored-By: Sviatoslav Sydorenko <webknjaz@redhat.com>

Merge TSan and UBSan CI matrices

219e287

webknjaz force-pushed the maintenance/111758-gha-combined-san branch from 115b8e3 to 219e287 Compare July 20, 2025 10:51

webknjaz marked this pull request as ready for review July 20, 2025 12:21

webknjaz requested review from AA-Turner, ezio-melotti and hugovk as code owners July 20, 2025 12:21

bedevere-app bot added the awaiting review label Jul 20, 2025

hugovk reviewed Jul 20, 2025

View reviewed changes

.github/workflows/reusable-san.yml Outdated Show resolved Hide resolved

Expand "free-threading" in the job label

50413d4

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

webknjaz requested a review from hugovk July 20, 2025 17:19

hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 20, 2025

hugovk approved these changes Jul 20, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Jul 20, 2025

hugovk merged commit 65d2c51 into python:main Jul 20, 2025
48 checks passed

bedevere-app bot removed the awaiting merge label Jul 20, 2025

miss-islington-app bot assigned hugovk Jul 20, 2025

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 20, 2025

AA-Turner added the sprint label Jul 20, 2025

webknjaz mentioned this pull request Jul 23, 2025

[3.13] GH-111758: Merge TSan and UBSan reusable GHA workflows (#136820) #137029

Merged

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 23, 2025

thesamesam mentioned this pull request Apr 6, 2026

Fail on new UB in CI #148168

Open

Uh oh!

Conversation

webknjaz commented Jul 19, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webknjaz Jul 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

webknjaz Jul 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

webknjaz commented Jul 20, 2025

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app bot commented Jul 20, 2025

Uh oh!

miss-islington-app bot commented Jul 20, 2025

Uh oh!

bedevere-app bot commented Jul 20, 2025

Uh oh!

hugovk commented Jul 20, 2025

Uh oh!

webknjaz commented Jul 20, 2025

Uh oh!

encukou commented Jul 21, 2025

Uh oh!

bedevere-app bot commented Jul 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

webknjaz commented Jul 19, 2025 •

edited by bedevere-app bot

Loading