Enable custom project-level resource quotas by rak-phillip · Pull Request #16550 · rancher/dashboard

rak-phillip · 2026-02-02T22:09:09Z

Summary

This updates the Project Resource Quotas tab so that custom resource quotas can now be specified.

Fixes #14797

Occurred changes and/or fixed issues

Add custom type to resource quotas
Load and modify custom resource quotas
Test for extended with computed props and consts
Fix failing unit tests
Add unit tests for custom types

Technical notes summary

The following changes were made to enable custom quotas:

Add a new item, Custom, to the Resource Type dropdown. This options can be selected multiple times
Add a new Resource Identifier input that becomes enabled when the Resource Type is "custom"; this allows the user to specify a custom quota

The relationship between the Project and ProjectRow components gets a little complicated with the custom quotas. The components are designed in such a way that "Resource Type" is expected to be unique, but this is no longer the case with multiple "Custom" quotas. I'll call out some code snippets to highlight where special consideration needs to be made.

Areas or cases that should be tested

Project resource quotas should behave as they did before, in addition to being able to add new custom quotas.

Areas which could experience regressions

Existing resource quotas should still behave the same with these changes in place.

Screenshot/Video

Checklist

The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
The PR has a Milestone
The PR template has been filled out
The PR has been self reviewed
The PR has a reviewer assigned
The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
The PR has been reviewed in terms of Accessibility
The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

This updates existing tests so that a new wrapper is initialized for each test. I encountered issues with tests mutating the wrapper. This update is a more idiomatic style for testing Vue components. Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

rak-phillip · 2026-02-02T23:09:12Z

shell/components/form/ResourceQuota/Project.vue

+    const limit = this.value.spec.resourceQuota.limit;
+    const extendedKeys = Object.keys(limit.extended || {});
+
+    this.typeValues = Object.keys(limit).flatMap((k) => {
+      if (k !== TYPES.EXTENDED) {
+        return k;
+      }
+
+      return extendedKeys.map((ek) => `extended.${ ek }`);
+    });


typeValues was originally an array of selected values:

[ "configMaps", "extended", "limitsCpu" ]

This pattern needed to be modified to work with multiple extended values, so we now produce an array that appends the custom types to extended:

[ "configMaps", "extended.test1", "extended.test2", "extended.test3", "limitsCpu" ]

rak-phillip · 2026-02-02T23:10:04Z

shell/components/form/ResourceQuota/Project.vue

          :mode="mode"
          :types="remainingTypes(typeValues[props.i])"
          :type="typeValues[props.i]"
+          :index="props.i"


It was just easier for me to think about the indexing by passing a prop and emitting the event along with the index.

rak-phillip · 2026-02-02T23:13:37Z

shell/components/form/ResourceQuota/ProjectRow.vue

+  created() {
+    if (this.type.startsWith(TYPES.EXTENDED)) {
+      this.customType = this.type.split('.')[1];
+    } else {
+      this.customType = this.type;


This is a side-effect of the updated typeValues pattern[^1]. Custom types will be strings formatted as extended.{ customType }..

edit: thinking about this more, this pattern needs some updating. This will break down with types like requests.nvidia.com/gpu.

Resolved with 9f20594

rak-phillip · 2026-02-02T23:15:29Z

shell/components/form/ResourceQuota/shared.js

+  EXTENDED:                'extended',
+  CONFIG_MAPS:             'configMaps',


I originally had a string constant for EXTENDED, but added CONFIG_MAPS to fix failing unit tests that were relying on specific order in the RANCHER_TYPES array. After I decided to migrate the rest after I added these.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

rak-phillip · 2026-02-03T00:08:43Z

The remove behavior is inaccurate.. this stems from the design of the ArrayList component and its usage array indexes as v-for keys #14742. I'm working on an alternative approach that will work for quotas.

codyrancher

The only reservation that I really had was the split between resource type and resourceIdentifier.

In my mind I think the UX I would've preferred would be just have a Resource Identifier with a taggable labeled select where the user could type in the custom identifier if needed.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

Adding a key to the ResourceQuota component will force it to re-render when the key is incremented. This resolves issues with the ArrayList component rendering incorrect rows because it uses an index as key in its v-for. This approach can incur a performance penalty, but I expect the number of rows to remain reasonably small; the added reliability of this approach is more important. Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

rak-phillip added 5 commits January 30, 2026 14:52

Add custom type to resource quotas

84a14fb

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

Load and modify resource quotas

6e15349

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

Test for extended with computed props and consts

5a7e768

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

Fix failing unit tests

36c9896

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

Add unit tests for custom types

281cb6b

This updates existing tests so that a new wrapper is initialized for each test. I encountered issues with tests mutating the wrapper. This update is a more idiomatic style for testing Vue components. Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

rak-phillip requested a review from codyrancher February 2, 2026 22:09

rak-phillip added 3 commits February 2, 2026 15:27

Add a tooltip to the Resource Identifier label

de8e5c1

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

Populate resource identifier with selected type

2e872a5

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

Add a banner to explain resource quotas

c1b6a8c

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

rancher-ui-project-bot bot added this to the v2.15.0 milestone Feb 2, 2026

Add docs link to Resource Quotas banner

ef6a44a

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

rak-phillip modified the milestones: v2.15.0, v2.14.0 Feb 2, 2026

Use toStrictEqual in unit tests

36552e0

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

rak-phillip commented Feb 2, 2026

View reviewed changes

Allow for custom resource types that contain periods

9f20594

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

codyrancher previously approved these changes Feb 3, 2026

View reviewed changes

rak-phillip added 2 commits February 3, 2026 10:27

Remove quotas from list

bd35848

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

Update banner and tooltip

c3dd0c5

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

rak-phillip dismissed codyrancher’s stale review via c3dd0c5 February 3, 2026 22:59

rak-phillip added 2 commits February 3, 2026 16:09

Add required indicator

15217c5

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

codyrancher self-requested a review February 4, 2026 23:19

codyrancher approved these changes Feb 4, 2026

View reviewed changes

rak-phillip merged commit ae9cd3b into rancher:master Feb 5, 2026
90 of 96 checks passed

rak-phillip deleted the task/14797-quotas branch February 5, 2026 01:08

mantis-toboggan-md mentioned this pull request Feb 12, 2026

Enhance Virtual CLuster Policy Resource Allocation UI rancher/virtual-clusters-ui#106

Open

rak-phillip mentioned this pull request Feb 27, 2026

Parse custom resource quotas as a flat list for editing Namespaces #16803

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable custom project-level resource quotas #16550

Enable custom project-level resource quotas #16550
rak-phillip merged 15 commits intorancher:masterfrom
rak-phillip:task/14797-quotas

rak-phillip commented Feb 2, 2026 •

edited

Loading

Uh oh!

rak-phillip Feb 2, 2026

Uh oh!

rak-phillip Feb 2, 2026

Uh oh!

rak-phillip Feb 2, 2026

Uh oh!

rak-phillip Feb 2, 2026

Uh oh!

rak-phillip Feb 2, 2026

Uh oh!

rak-phillip commented Feb 3, 2026

Uh oh!

codyrancher left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

rak-phillip commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

Uh oh!

rak-phillip Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

rak-phillip Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

rak-phillip Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

rak-phillip Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

rak-phillip Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

rak-phillip commented Feb 3, 2026

Uh oh!

codyrancher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rak-phillip commented Feb 2, 2026 •

edited

Loading