Parse custom resource quotas as a flat list for editing Namespaces#16803
Merged
rak-phillip merged 3 commits intorancher:masterfrom Feb 27, 2026
Merged
Conversation
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
codyrancher
approved these changes
Feb 27, 2026
Member
codyrancher
left a comment
There was a problem hiding this comment.
Only one thing, I don't think it'll be an issue but I wanted to bring it up just in case.
| limit: { | ||
| ...this.value.resourceQuota.limit, | ||
| [key]: value | ||
| this.value['resourceQuota'] = { limit: this.limitsFromFlatList(key, value) }; |
Member
There was a problem hiding this comment.
I don't think this is actually a problem and it was already present but I figured I'd bring it up just in case I'm missing something.
If resourceQuota ever had a properties outside of limit we would clobber it here by creating a new object and assigning it to resourceQuota.
Member
Author
There was a problem hiding this comment.
The main difference here is how we populate limits, otherwise this should be the same behavior as before:
dashboard/shell/components/form/ResourceQuota/Namespace.vue
Lines 59 to 68 in 7ac7bd6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This parses custom resource quotas as a flat list so that any values under the "extended" key read by the namespace edit form.
Fixes #16798
Occurred changes and/or fixed issues
Technical notes summary
This is very similar to the original approach taken in #16550, where we would flatten all of the properties under extended to produce a collection of keys prefixed with
extended.. I think that this approach is safe here because this form does not deal with ArrayList.vue and we are not adding/removing resource quotas for the namespace form.Areas or cases that should be tested
See issue for more details:
Areas which could experience regressions
Pay attention to the functions that parse to and from flat lists. If there's an error in the logic, we could fail to render/save the form properly.
Screenshot/Video
Checklist
Admin,Standard UserandUser Base