Fix findLabelSelector and matchingLabelSelector by richard-cox · Pull Request #16707 · rancher/dashboard

richard-cox · 2026-02-19T15:38:58Z

Summary

Fixes #15529
Fixes #16732

Occurred changes and/or fixed issues

findLabelSelector
- Ensure we correctly set the record of what's in the cache... with what's actually in the cache
- This became out of sync
  - we were clearing the cache and setting the collection to one relevant to a labelSelector
  - we were then adding labelSelector to a record saying we had this
  - the record was ADDED to after every call instead of being reset
- fixes vai off world
  - we fetch pods for service 1 --> change to service 2 --> we fetch pods for service 2 (cache clears pods for service 1 BUT not the record of them) --> change to service 1 --> cache has record of service 1 pods so returns all in cache, however pods are for service 2
  - we now ensure the cache list and record match matching pods
  - this doesn't affect via on world because we handle labelSelector filters like normal filters in a findPage request
matchingLabelSelector
- this getter is only used in services and workload views to get pods associated with them
- we look at the cache and get applicable resources given the labelSelector
- the cache can have just the results of the labelSelector, or more and we should then apply the labelSelector to it
- the fix here is to ensure that we're applying the label selector to the findPage scenario
- fixes vai on world
  - we fetch pods for service 1 --> change to service 2 --> show cache containing pods from service 1 --> fetch pods for service 2 --> cache updates and we show the correct ones
  - to avoid this ensure we always run the selector on the pods in the cache
  - this does not affect vai off world because the cache only contains the results of the labelSelector
empty services list in deployment detail page
- Deployment Detail Page: Services list is always empty #16732, https://github.com/rancher/dashboard/pull/16364/changes#diff-8feb714b5665e764f50a90fd673235de56b8be1d1956d023d8226094ef36df91L60-L61
- I think the lines to fetch the services was mistakenly removed when refactoring the selector to a model relatedServices getter
- i fixed this here to unblock one of the regression tests

Technical notes summary

Also fixed an issue where the selector was ignored when fetching matching pods

Areas or cases that should be tested

With vai off and on

Core bug
- Find two services with different amounts of associated Pods
- Flick multiple times between the detail page of each service and ensure the Pods list contains the correct values
- Also refresh on a service detail page and ensure Pods list contains correct values

Areas which could experience regressions

With vai off and on

matchingLabelSelector
- Find two deployments with different amount of pods
- Flick multiple times between the detail page of each deployment and ensure the Pods list contains the correct values
- Also refresh on a detail page and ensure Pods list contains correct values
Longhorn - (after install)
- --> on cluster explorer Longhorn Overview page should show card with link to longhorn service --> click --> should load long horn ui (page just needs to load, it can show errors)
- cluster explorer --> Deployment --> longhorn-ui Detail page --> services list should be populated
Compliance (replacement app for CIS Benchmark)
- cluster tools --> install compliance app
- load https://raw.gh.umua.top/rancher/compliance-operator/refs/heads/main/tests/k3s-bench-test.yaml, copy url, apply yaml in target cluster
- wait for scan to complete --> click on a scan --> Shows entries
- Unrelated issue - Cluster Scan: Detail page: Missing/missaligned header info #16735

Checklist

The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
The PR has a Milestone
The PR template has been filled out
The PR has been self reviewed
The PR has a reviewer assigned
The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
The PR has been reviewed in terms of Accessibility
The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

- findLabelSelector - Ensure we correctly set the state of the cache given the values in the collection - e.g. if we've cleared the cache for a specific selector mark other selectors as missing - matchingLabelSelector - if we've fetched a page assume it's a trimmed down result set ready for further trimming by selector

richard-cox · 2026-02-23T09:42:47Z

shell/plugins/dashboard-store/mutations.js

    }

-    cache.haveSelector[selector] = true;
+    cache.haveSelector = { [selector]: true };


at some point we should remove the map part and just use cache.haveSelector=selector i chickened out though given this is bug complete week.

i can create a tech debt issue if requested

richard-cox · 2026-02-23T09:43:36Z

shell/plugins/dashboard-store/getters.js

    // Filter first by namespace if one is provided, since this is efficient
    if (namespace && typeof namespace === 'string') {
-      matching = type === POD ? getters['podsByNamespace'](namespace) : matching.filter((obj) => obj.namespace === namespace);
+      matching = type === POD && !selector ? getters['podsByNamespace'](namespace) : matching.filter((obj) => obj.namespace === namespace);


this is a secondary fix. matchingLabelSelector calls matching. if there's a selector we shouldn't return all pods in a namespace but go on to apply it

… page

richard-cox · 2026-02-23T10:55:06Z

shell/detail/workload/index.vue

      hash.pods = this.value.fetchPods();
    }

+    if (this.serviceSchema) {


this was the fix for #16732

Copilot

Pull request overview

Fixes caching inconsistencies when fetching resources by label selector (notably pods for Services/Workloads) across both VAI pagination-enabled and disabled modes, and restores missing service fetching on workload detail pages.

Changes:

Reset selector-cache bookkeeping in loadSelector to avoid accumulating stale selectors.
Ensure matchingLabelSelector applies the label selector when the store currently represents a paginated result set.
Re-add fetching of Services in the workload detail view to populate related-services UI.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
`shell/plugins/dashboard-store/mutations.js`	Adjust selector-cache tracking to avoid stale selector records.
`shell/plugins/dashboard-store/getters.js`	Apply label selector filtering when cache contains a page/all rather than a selector-only result set.
`shell/plugins/dashboard-store/actions.js`	Fix typo in comment in `findLabelSelector` option handling.
`shell/detail/workload/index.vue`	Fetch namespaced Services during workload detail load to repopulate related services list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

shell/plugins/dashboard-store/getters.js

shell/plugins/dashboard-store/mutations.js

codyrancher

lgtm

richard-cox added this to the v2.14.0 milestone Feb 19, 2026

rancher-ui-project-bot bot assigned richard-cox Feb 19, 2026

richard-cox force-pushed the fix-findLabelSelector branch from ac9d706 to 34933d2 Compare February 23, 2026 09:37

richard-cox commented Feb 23, 2026

View reviewed changes

Ensure we fetch services in order to show them in the workload detail…

1cd1df7

… page

richard-cox marked this pull request as ready for review February 23, 2026 10:54

richard-cox requested a review from codyrancher February 23, 2026 10:54

richard-cox commented Feb 23, 2026

View reviewed changes

richard-cox requested a review from Copilot February 23, 2026 10:57

Copilot started reviewing on behalf of richard-cox February 23, 2026 10:57 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

shell/plugins/dashboard-store/getters.js Show resolved Hide resolved

shell/plugins/dashboard-store/mutations.js Show resolved Hide resolved

Changes after copilot review

fb0e8e9

richard-cox mentioned this pull request Feb 23, 2026

Fix findlabelSelector when vai enabled but resource type not supported #16734

Merged

9 tasks

codyrancher approved these changes Feb 24, 2026

View reviewed changes

richard-cox merged commit cfe38a3 into rancher:master Feb 24, 2026
42 checks passed

richard-cox deleted the fix-findLabelSelector branch February 24, 2026 10:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix findLabelSelector and matchingLabelSelector#16707

Fix findLabelSelector and matchingLabelSelector#16707
richard-cox merged 3 commits intorancher:masterfrom
richard-cox:fix-findLabelSelector

richard-cox commented Feb 19, 2026 •

edited

Loading

Uh oh!

richard-cox Feb 23, 2026

Uh oh!

richard-cox Feb 23, 2026 •

edited

Loading

Uh oh!

richard-cox Feb 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

codyrancher left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

richard-cox commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Checklist

Uh oh!

richard-cox Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

richard-cox Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

richard-cox Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

codyrancher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

richard-cox commented Feb 19, 2026 •

edited

Loading

richard-cox Feb 23, 2026 •

edited

Loading